Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code clarity #70

Open
dissolve opened this issue May 22, 2017 · 3 comments
Open

Improve code clarity #70

dissolve opened this issue May 22, 2017 · 3 comments

Comments

@dissolve
Copy link
Collaborator

getting a code climate score of 0.7, which is pretty abysmal.
While i don't agree with all of the rules they use, there is a lot of work that can be done to improve the readability of the code base.

@jgarber623 jgarber623 changed the title inprove code clarity Improve code clarity Jul 2, 2018
@dissolve
Copy link
Collaborator Author

i have a branch called rubocop-cleanup which is tackling this.

However I wanted to discuss with @jgarber623 the thoughts on what defines a breaking change.

I am adding a new class that all of the results classes inherit from. technically someone could be testing for the name of the class's direct parent. It would be very foolish to do so, but this could potentially break things for them. It seems like a really obscure case that should not be done anyway.

@jgarber623
Copy link
Member

Version numbers are cheap, so I'm totally fine if we want to play it safe and flag to users of the gem the potential for breakage (edge case usage notwithstanding).

Good refactoring on that results class, too. 👍

@jgarber623
Copy link
Member

☝🏻 The implication there being that the next release of the gem would be 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants