-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sophisticated url normalization #21
Comments
I think this should be created at a standalone gem that this gem then depends on. |
@aaronpk said he'd take this on and would build it as a stand alone gem. This gem would then need to depend upon and use it. |
Hmm this gem might already do it: https://github.com/sporkmonger/addressable Take a look at the "join" method. |
For reference, @aaronpk is talking about this method. |
At quick glance, seems good. I'll leave it up to implementors to decide whether to use that or create a new gem (if addressable) ends up to be insufficient. |
I've just recently abstracted some similarly duplicative code from my own projects into the Absolutely gem which relies on Addressable under-the-hood. I'll add some more test cases from @aaronpk's aforelinked php-mf2 test suite for completeness. |
…and done! Absolutely v1.1.0 adds tests from the php-mf2 URL test suite. |
@jgarber623 You have the Absolutely repo tagged https://github.com/topics/absolute-ur vs |
@veganstraightedge Good catch. Thanks! |
php-mf2 tests are comprehensive https://github.com/indieweb/php-mf2/blob/master/tests/Mf2/URLTest.php
The text was updated successfully, but these errors were encountered: