Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to select multiple sample type environment #1367

Open
mslarae13 opened this issue Aug 13, 2024 · 21 comments · May be fixed by #1372
Open

Add ability to select multiple sample type environment #1367

mslarae13 opened this issue Aug 13, 2024 · 21 comments · May be fixed by #1372
Assignees

Comments

@mslarae13
Copy link

Currently, NMDC submission portal has a radio button to select only 1 type of sample (soil, water, sediment, etc)

We'd like this to be checkboxes and all for 1 study to have multiple sample types in 1 submission.

  • IF submitting for JGI and EMSL, all the sample types will need to populate the JGI and EMSL tabs the same way the single sample does
  • Need to make sure the sample type is populated for each sample when the ingest to mongo happens
  • Can we update Environmental Packages to Environmental Extensions to accurately match GSC
@mslarae13
Copy link
Author

@mslarae13
Copy link
Author

mslarae13 commented Aug 13, 2024

@ssarrafan ssarrafan assigned ssarrafan and marySalvi and unassigned ssarrafan Aug 14, 2024
@ssarrafan
Copy link

Assigning to @marySalvi for next sprint per the meeting with Emiley, Alicia and Chris today.

@mslarae13
Copy link
Author

@marySalvi feel free to move this issue to the correct repo!

@marySalvi marySalvi transferred this issue from microbiomedata/issues Aug 25, 2024
@marySalvi marySalvi linked a pull request Aug 29, 2024 that will close this issue
@ssarrafan
Copy link

Discussed at infra sync and it's more complicated that expected. @marySalvi still working on this.

@pkalita-lbl
Copy link
Collaborator

The proposed changes will require changes in the Field Notes app. Cross-linking that issue here: microbiomedata/nmdc-field-notes#177

@mslarae13
Copy link
Author

Work will be complete by end of September to satisfy milestone.
Roll out to production will NOT happen with September roll out.
Roll out can happen in October, updates to the app should be done in time.

@mslarae13
Copy link
Author

mslarae13 commented Sep 19, 2024

Will NOT be part of

@ssarrafan
Copy link

Moving to next sprint per updates by @mslarae13
thank you

@ssarrafan
Copy link

Will this issue be completed this sprint? @marySalvi @mslarae13

@marySalvi
Copy link
Collaborator

Will this issue be completed this sprint? @marySalvi @mslarae13

Yes, it should be

@mslarae13
Copy link
Author

Decision today at infrastructure sync: will not merge until after berkeley-schema is in production, so after oct 15. There will be merge conflicts

@ssarrafan
Copy link

ssarrafan commented Oct 4, 2024

@marySalvi @mslarae13 so can this be considered done (for DOE report purposes) but moved to the next sprint for production deployment? Or is it not quite done yet?

@marySalvi
Copy link
Collaborator

I think this can be considered done but should not be merged until after Oct 15th

@mslarae13
Copy link
Author

Ready to merge?

@mslarae13
Copy link
Author

@marySalvi @pkalita-lbl
Any updates here? I believe the PR noted that if this is merged it'll break the app.

@pkalita-lbl
Copy link
Collaborator

No no no, I would like this to be merged into main sooner than later so that I can complete some app updates.

@marySalvi
Copy link
Collaborator

marySalvi commented Oct 29, 2024

No no no, I would like this to be merged into main sooner than later so that I can complete some app updates.

I have rebased my runtime code and created the PR below.
microbiomedata/nmdc-runtime#741

I'll work on rebasing my PR on nmdc-server now. Once both are ready we should be able to merge.

@pkalita-lbl for the runtime PR I adjusted the tests and everything is passing. I would feel more comfortable if I saw the finished products in the DB but I didn't see any test entries in the DB. Am I right in thinking they get deleted in cleanup?

@mslarae13
Copy link
Author

Blocked. Coordinating changes in run-time. Major change in the way sample data is stored. Run time translates submission data into mongo. Mary has started working on this.

@mslarae13
Copy link
Author

@marySalvi status on this?

@mslarae13
Copy link
Author

@marySalvi is addressing a bug in runtime.
Correct me if that's wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❌Blocked
Development

Successfully merging a pull request may close this issue.

4 participants