Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

total bases and gene counts issues #49

Closed
aclum opened this issue Aug 14, 2024 · 1 comment · Fixed by #51
Closed

total bases and gene counts issues #49

aclum opened this issue Aug 14, 2024 · 1 comment · Fixed by #51
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented Aug 14, 2024

These are null in the sdb file, b/c they are generated in a downstream step in the JGI workflow, as currently written this would get propagated to mongo via the json. Please update mbin_stats.py to calculate these on fly for json file that is output.

@chienchi
Copy link
Collaborator

Total bases can be counted with the bins fasta files. The gene count will need to wait till task package step when each bin linked with associated annotation files. So, the both total base and gene count function will be better to add in the create_tarfiles.py script and update the mags_stats.json file.

@chienchi chienchi linked a pull request Aug 20, 2024 that will close this issue
@chienchi chienchi moved this from In Progress to In Review in 2024 - Sprint 43 - August 12-23, 2024 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants