Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest tests fails when upgrading to i18n-iso-countries 7.7.0 #336

Open
NidalShaterM opened this issue Sep 18, 2023 · 0 comments
Open

Jest tests fails when upgrading to i18n-iso-countries 7.7.0 #336

NidalShaterM opened this issue Sep 18, 2023 · 0 comments

Comments

@NidalShaterM
Copy link

NidalShaterM commented Sep 18, 2023

we are using i18n-iso-countries in some functions and when the library is upgraded to 7.7.0, Jest tests are now failing like this:

 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
      Type 'undefined' is not assignable to type 'string'.

    232     country_code: getAlpha2Code(transactionInput.country.trim(), 'en'),

we pinned it to version 7.6.0 for now but would like for this issue to be resolved so we keep up with the updates

I guess this is caused by this commit
287a1ae#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8R21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant