Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop event sometimes thrown too early #47

Open
pndewit opened this issue May 1, 2018 · 2 comments
Open

Drop event sometimes thrown too early #47

pndewit opened this issue May 1, 2018 · 2 comments

Comments

@pndewit
Copy link

pndewit commented May 1, 2018

Using your example project: https://github.com/michaelmalonenz/aurelia-dragula-example

  1. Add a breakpoint, console log, or anything else to notify you (that it has been triggered) on line 32 in welcome.js (so just inside the drop function)
  2. Start it up and submit the name: "test"
  3. For reference move first letter to any position and note that when dropped, the breakpoint should stop execution. The letter should be changed to the position you dropped it.
  4. Now move the last (right) letter and change its position in the list to any other position. Note that when the breakpoint stops execution, the letter should have returned to its previous position (completely right). When you continue execution the letter should move to its new position.
@michaelmalonenz
Copy link
Owner

This is the "flicker" I was referring to in the previous issue. I can't fix this for the last letter, I don't think. Either that, or fixing the test for _isInitialPosition will solve this issue.

@pndewit
Copy link
Author

pndewit commented May 1, 2018

hm, so as far as you know there is no way to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants