feat: add a function for GET /api/overview #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikrivosheev
force-pushed
the
feat/api_overview
branch
from
ab1f820
to
55f750f
Compare
| pub cluster_name: String, | ||
| pub erlang_full_version: String, | ||
| pub erlang_version: String, | ||
| pub management_version: String, |
There was a problem hiding this comment.
This will never be different from rabbitmq_version, I don't think we need it (neither do we need it in the API response but it will take a deprecation period before it can be removed).
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaelklishin hello! I need
overviewAPI for checks.A note: I didn't add all fields. I saw that there is different in response between rabbitmq version and I think we have to think about MSRV (minimum support rabbitmq version). Or add new features for different rabbitmq versions...