Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index out of range error in match_times #17

Open
ctsexton opened this issue Apr 11, 2019 · 2 comments
Open

Index out of range error in match_times #17

ctsexton opened this issue Apr 11, 2019 · 2 comments

Comments

@ctsexton
Copy link
Member

ctsexton commented Apr 11, 2019 •
edited
Loading

With unexpected inputs out of range, a negative list index can be generated in match_times (analyze_estimates.py).

performance_tracker/performance_tracker/analyzer/analyze_estimates.py

Line 20 in afbaee2

lambda x: schedule.index[schedule.index.get_loc(x, method="nearest")]

@ctsexton
Copy link
Member Author

Commit afbaee2 is a temporary fix - throwing out invalid values. We could dig a bit deeper into understanding what causes this error.

@tavinathanson
Copy link

Probably worth logging when this happens versus throwing it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tavinathanson @ctsexton