Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Bounded Cache with Context #7

Open
ikitommi opened this issue Jul 30, 2019 · 2 comments · May be fixed by #15
Open

Use Bounded Cache with Context #7

ikitommi opened this issue Jul 30, 2019 · 2 comments · May be fixed by #15
Labels
enhancement help wanted

Comments

@ikitommi
Copy link
Member

The default implementation stores all unique SQL sentences on a HashMap, which is a potential memoery leak. The default should be a fast bounded cache.
@bsless
Copy link

bsless commented Jul 6, 2020

Thoughts on using Caffeine as a default cache backend? Already has Clojure wrappings
Another option is using core.cache.
Caffeine is probably more battle-tested.
I'd be happy to implement the chosen solution.

@janosmeszaros janosmeszaros linked a pull request Dec 12, 2021 that will close this issue
Open
@janosmeszaros
Copy link
Contributor

@ikitommi @bsless I spent some time today adding a caching layer, see #15. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a caching layer janosmeszaros/porsas
3 participants
@ikitommi @janosmeszaros @bsless