Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more Response-types #5

Open
ikitommi opened this issue Jul 9, 2019 · 4 comments
Open

Support more Response-types #5

ikitommi opened this issue Jul 9, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@ikitommi
Copy link
Member

ikitommi commented Jul 9, 2019

  • File, InputStream at least
@ikitommi ikitommi added the enhancement New feature or request label Jul 9, 2019
@ohpauleez
Copy link

As always, love to see this stuff. Current version of "Pedestal2" has many similarities with the approach here.

You might consider changing from CompletableFuture to CompletionStage in response.clj. (More than happy to elaborate here, but I think you'll get the main idea).

@ikitommi
Copy link
Member Author

Good catch, thanks! Curious about the "Pedestal2", didn't find anything on the pedestal repo, any more info available? We are in process of pulling a set of libraries into a new opinionated developer-friendly stack, will end up here: https://github.com/metosin/talvi

Logo-driven development ;)

@malchmih
Copy link

Same here, would love for this project to take off!

@kanwei
Copy link

kanwei commented Oct 13, 2019

It definitely seems like implementing this ticket would allow adoption by folks like me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants