Allow calibration CLI to retrieve nc from directories #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Just to check. Did you mean to keep this in review now that metoppv/improver#2033 is in draft? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow removal of superfluous edges from the calibration graphing, we are looking to pass directories instead of files to the calibration CLIs (construct-reliability-tables and estimate-emos-coefficients). This requires an update to the directory structure of the acceptance test data so the plugin can parse all netcdfs in a given directory (e.g. all truths in one directory, all forecasts in another, and no results/outputs in either)
Related PRs