Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little cleanup for new purpose of the repo #3

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Little cleanup for new purpose of the repo #3

merged 8 commits into from
Nov 29, 2023

Conversation

PicoCentauri
Copy link
Contributor

No description provided.

@frostedoyster
Copy link
Collaborator

Explaining all the commits:

  • first, we were relying on setup.py to build sdist and wheels, but there is no setup.py anymore
  • second, we couldn't find the sdist to build the wheels from, because its name changed from metatensor-models to metatensor_models
  • third, the final command of the build-python test environment only works if called from bash -c. No clue why.

I'm opening an issue to restore the naming to metatensor-models because that's more consistent with our other packages

@frostedoyster
Copy link
Collaborator

@PicoCentauri you can merge if you think this is ready. From here, I'll try to make some progress towards the MVP and you can clean up more

@PicoCentauri PicoCentauri merged commit fbdffd5 into main Nov 29, 2023
5 checks passed
@PicoCentauri PicoCentauri deleted the skeleton branch November 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants