Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove consistency checks (except for tests) #293

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Remove consistency checks (except for tests) #293

merged 6 commits into from
Jul 18, 2024

Conversation

frostedoyster
Copy link
Collaborator

@frostedoyster frostedoyster commented Jul 12, 2024 •
edited by github-actions bot
Loading

Fixes #292

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

📚 Documentation preview 📚: https://metatrain--293.org.readthedocs.build/en/293/

Luthaf
Luthaf reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@Luthaf Luthaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, just one discussion point on the CLI API

src/metatrain/cli/eval.py Outdated Show resolved Hide resolved
@Luthaf Luthaf merged commit e2fb721 into main Jul 18, 2024
12 of 13 checks passed
@Luthaf Luthaf deleted the consistency-checks branch July 18, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PicoCentauri PicoCentauri PicoCentauri left review comments

@Luthaf Luthaf Luthaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove check_consistency everywhere except in tests
3 participants
@frostedoyster @Luthaf @PicoCentauri