Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture version when checkpointing #351

Open
PicoCentauri opened this issue Oct 3, 2024 · 0 comments
Open

Add architecture version when checkpointing #351

PicoCentauri opened this issue Oct 3, 2024 · 0 comments
Labels
Priority: Medium Important issues to address after high priority.

Comments

@PicoCentauri
Copy link
Contributor

When loading a checkpoint from an older version of metatrain using a architecture's load_checkpoint and the architecture changes one may gets a very cryptic error message like

RuntimeError: Error(s) in loading state_dict for SoapBpnn:
	Missing key(s) in state_dict: "composition_weights". 
	Unexpected key(s) in state_dict: "composition_model.weights".

To improve this we should add an architecture version inside the checkpoint and check this against the current architecture version. If they disagree we can raise a better error message. The version could be just a simple integer.

@PicoCentauri PicoCentauri added the Priority: Medium Important issues to address after high priority. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Important issues to address after high priority.
Projects
None yet
Development

No branches or pull requests

1 participant