✨ Prevent BMH from transitioning when an invalid BIOS setting is detected #1889
Conversation
This update ensures that the BMH (Bare Metal Host) does not transition to the next state when an invalid BIOS setting is detected. This pause allows the user to correct the settings before proceeding with the installation. Additionally, a new error type has been added to specifically handle user configuration errors. Signed-off-by: Tao Liu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
needs-ok-to-test
|
Hi @tliu2021. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
metal3-io-bot
added
the
size/M
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
| switch { | ||
| case errors.As(err, &ConfigurationError{}): | ||
| // wait for the user to correct the error | ||
| return actionContinue{configurationErrRetryDelay} |
There was a problem hiding this comment.
Why is it different from what we had before? You're only changing the retry delay for 1 to 1.5 minutes. Did you intend to you something else than actionContinue?
There was a problem hiding this comment.
Previously, the operation did not return an error, and there was no retry delay (see line 1892 below).
There was a problem hiding this comment.
I think on line 1132 the error would be returned in any case.
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
|
This behavior needs to be triggered based on a label in the HFS or BMH. |
What this PR does / why we need it:
Currently, the installation process ignores invalid BIOS settings, which can result in a system booting without the desired configuration. This commit ensures that the process halts when an invalid BIOS setting is detected, allowing the user to correct the issue before proceeding, thereby preventing unintended configurations.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #