Add ego car color in top down view and fix expert bug. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting for check |
pengzhenghao
reviewed
Aug 8, 2024
Comment on lines
460
to
+464
| elif MetaDriveType.is_vehicle(type): | ||
| ret = np.array([224, 177, 67]) | ||
| # self vehicle | ||
| elif MetaDriveType.is_ego_vehicle(type): | ||
| ret = np.array([67, 177, 224]) |
There was a problem hiding this comment.
Will this work if is_vehicle call before is_ego_vehicle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes do you make in this PR?
Use config copy in expert to avoid origin config changing.
Now cars in semantic top-down view are draw with the same colors. But the color of ego car should be distinguished. Ego car use constant "EGO_VEHICLE" will be better.
Checklist
bash scripts/format.shbefore merging.