Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable staging Firebase database #218

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Enable staging Firebase database #218

merged 5 commits into from
Feb 5, 2024

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented Jan 5, 2024

Problem

What is the problem this work solves, including
#214

Solution

What I/we did to solve this problem

  • stored staging firebase database credentials in a .env file
    • the .env should look like:
      FIREBASE_TOKEN=["private_key"]
      FIREBASE_EMAIL=["client_email"]
  • developed functions that allow user to choose from dev or stag db

Next steps:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. obtain credentials to put in the .env (Ruge will invite @mogres to cellPACK staging db)
  2. upload a recipe to staging - upload -r examples/recipes/v2/one_sphere.json
  3. pack the uploaded recipe - pack -r firebase:recipes/one_sphere_v_1.0.0 -c examples/packing-configs/run.json
  4. pack a local recipe and choose a database to save the result file metadata

Screenshots (optional):

Screenshot 2024-01-04 at 4 28 16 PM

Copy link

github-actions bot commented Jan 5, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb4c0fa) 98.63% compared to head (95836aa) 98.63%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          18       18           
  Lines         511      511           
=======================================
  Hits          504      504           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rugeli rugeli marked this pull request as draft January 5, 2024 19:37
@rugeli rugeli marked this pull request as ready for review January 19, 2024 19:03
Copy link
Member

@meganrm meganrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, sorry this took so long to review!

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the update.

Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the update.

@rugeli rugeli merged commit 227e7f2 into main Feb 5, 2024
7 checks passed
@rugeli rugeli deleted the feature/firebase-cred-new branch February 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants