-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Consistent Use of MeshKit Errors in Meshery-Linkerd. #583
Comments
Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack. |
hi i would like to work on this issue |
Thanks for hopping in @moazfarrukh, here you go. |
@moazfarrukh Just following up, could you please provide an update on the progress here? |
@singh1203 yes i have started working on it. I have built the project i have been testing each error by trying to trigger to them to properly understand their behavior before refactoring them, which is taking me a while because there are more than 200 instances of errors in the whole project. i will try to make major progress over this weekend. |
That's excellent! However, I recommend creating a draft PR to represent the progress in the upcoming meshery dev meeting. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Current Behavior
Currently, there are instances where errors are being used directly instead of MeshKit errors, which impacts the consistency and quality of error reporting across the project.
Desired Behavior
References
Meshery Documentation on Meshkit
Make sure to follow these guidelines during writing Meshkit errors
https://discuss.layer5.io/t/best-practices-for-writing-meshkit-errors/5536
Also here is an example PR to which you can refer:
#11340
Contributor Guides and Resources
The text was updated successfully, but these errors were encountered: