Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Consistent Use of MeshKit Errors in Meshery-Linkerd. #583

Closed
2 tasks
singh1203 opened this issue Aug 8, 2024 · 8 comments
Closed
2 tasks

Ensure Consistent Use of MeshKit Errors in Meshery-Linkerd. #583

singh1203 opened this issue Aug 8, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature language/go

Comments

@singh1203
Copy link

singh1203 commented Aug 8, 2024

Current Behavior

Currently, there are instances where errors are being used directly instead of MeshKit errors, which impacts the consistency and quality of error reporting across the project.

Desired Behavior

  • Replace all direct usages of errors with MeshKit errors.
  • Ensure that each MeshKit error includes:- Short Description, Long Description, Probable Cause & Suggested Remediation.

References

Meshery Documentation on Meshkit


Contributor Guides and Resources

@singh1203 singh1203 added kind/enhancement Improvement in current feature language/go labels Aug 8, 2024
Copy link

welcome bot commented Aug 8, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack.

@singh1203 singh1203 added the good first issue Good for newcomers label Aug 8, 2024
@moazfarrukh
Copy link

hi i would like to work on this issue

@singh1203
Copy link
Author

hi i would like to work on this issue

Thanks for hopping in @moazfarrukh, here you go.

@singh1203
Copy link
Author

@moazfarrukh Just following up, could you please provide an update on the progress here?

@moazfarrukh
Copy link

@singh1203 yes i have started working on it. I have built the project i have been testing each error by trying to trigger to them to properly understand their behavior before refactoring them, which is taking me a while because there are more than 200 instances of errors in the whole project. i will try to make major progress over this weekend.

@singh1203
Copy link
Author

@singh1203 yes i have started working on it. I have built the project i have been testing each error by trying to trigger to them to properly understand their behavior before refactoring them, which is taking me a while because there are more than 200 instances of errors in the whole project. i will try to make major progress over this weekend.

That's excellent! However, I recommend creating a draft PR to represent the progress in the upcoming meshery dev meeting.

Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 12, 2024
Copy link

stale bot commented Nov 5, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature language/go
Projects
None yet
Development

No branches or pull requests

2 participants