Feature/width-height-units #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not happy with the fire resize event, though it fixes the height issue... it has to many side affects... It's not ready for merging. |
|
Fixed it with setting the relative size after loading and removed the refresh event |
Andries-Smit
force-pushed
the
feature/width
branch
from
db30acf
to
fb90591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove maintaining aspect ratio code. (code was not/never functional)
The width and height were directly set onto the
this.domNodeby some unknown feature of Dojo or Mendix. Needed to create own rendering and deleting the attributethis.widthandthis.heightto fix it to support percentage units.