Skip to content

Commit

Permalink
Code refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
Jelte Lagendijk committed Apr 18, 2016
1 parent c1a7f91 commit 4fb01d4
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 74 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"generatorVersion": "1.3.3",
"paths": {
"testProjectFolder": "./test/",
"testProjectFileName": "Test.mpr"
"testProjectFileName": "DynamicImageWidget.mpr"
},
"scripts": {
"test": "grunt test"
Expand Down
1 change: 0 additions & 1 deletion src/DynamicImage/widget/DynamicImage.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ define([

postCreate: function () {
logger.debug(this.id + ".postCreate");
this._updateRendering();
},

update: function (obj, callback) {
Expand Down
3 changes: 1 addition & 2 deletions src/DynamicImage/widget/MobileDynamicImage.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@

define([
"dojo/_base/declare", "DynamicImage/widget/DynamicImage"
], function (declare, DynamicImage) {
"use strict";

// Declare widget"s prototype.
return declare("DynamicImage.widget.MobileDynamicImage", [DynamicImage]);

});
require(["DynamicImage/widget/MobileDynamicImage"], function () {
"use strict";
Expand Down
74 changes: 4 additions & 70 deletions src/DynamicImage/widget/MobileStaticImage.js
Original file line number Diff line number Diff line change
@@ -1,77 +1,11 @@

define([
"dojo/_base/declare", "mxui/widget/_WidgetBase", "dijit/_TemplatedMixin",
"mxui/dom", "dojo/dom", "dojo/query", "dojo/dom-prop", "dojo/dom-geometry", "dojo/dom-class", "dojo/dom-style", "dojo/dom-construct", "dojo/_base/array", "dojo/_base/lang", "dojo/text", "dojo/html", "dojo/_base/event",
"dojo/text!DynamicImage/widget/template/DynamicImage.html"
], function (declare, _WidgetBase, _TemplatedMixin, dom, dojoDom, domQuery, domProp, domGeom, domClass, domStyle, domConstruct, dojoArray, lang, text, html, event, widgetTemplate) {
"dojo/_base/declare", "DynamicImage/widget/StaticImage"
], function (declare, StaticImage) {
"use strict";

return declare("DynamicImage.widget.MobileStaticImage", [_WidgetBase, _TemplatedMixin], {

// _TemplatedMixin will create our dom node using this HTML template.
templateString: widgetTemplate,

_handles: null,
_contextObj: null,

constructor: function () {
this._handles = [];
},

postCreate: function () {
logger.debug(this.id + ".postCreate");
},

update: function (obj, callback) {
logger.debug(this.id + ".update");

this._contextObj = obj;
this._resetSubscriptions();
this._updateRendering(callback);
},

// Rerender the interface.
_updateRendering: function (callback) {
logger.debug(this.id + "._updateRendering");

if (this.imageurl !== "") {
this.imageNode.src = this.imageurl;
} else {
this.imageNode.src = this.defaultImage;
}

mendix.lang.nullExec(callback);
},

// Reset subscriptions.
_resetSubscriptions: function () {
logger.debug(this.id + "._resetSubscriptions");
var _objectHandle = null;

// Release handles on previous object, if any.
if (this._handles) {
this._handles.forEach(function (handle, i) {
mx.data.unsubscribe(handle);
});
this._handles = [];
}

// When a mendix object exists create subscribtions.
if (this._contextObj) {

_objectHandle = this.subscribe({
guid: this._contextObj.getGuid(),
callback: lang.hitch(this, function (guid) {
this._updateRendering();
})
});


// Declare widget"s prototype.
return declare("DynamicImage.widget.MobileStaticImage", [StaticImage]);

this._handles = [_objectHandle];
}
}
});
});
require(["DynamicImage/widget/MobileStaticImage"], function () {
"use strict";
Expand Down
1 change: 1 addition & 0 deletions src/DynamicImage/widget/StaticImage.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ define([

update: function (obj, callback) {
logger.debug(this.id + ".update");

this._contextObj = obj;
this._resetSubscriptions();
this._updateRendering(callback);
Expand Down
Binary file modified test/widgets/DynamicImage.mpk
Binary file not shown.

0 comments on commit 4fb01d4

Please sign in to comment.