Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(floating-action-button): use native driver warning #84

Conversation

Ahmad-Elsayed
Copy link
Contributor

@Ahmad-Elsayed Ahmad-Elsayed commented Oct 13, 2023

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 7️⃣, 8️⃣, 9️⃣
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

...

Relevant changes

Please add a high level explanation of what was changed and how the initial problem was solved

What should be covered while testing?

...

Extra comments (optional)

Please add extra comments or delete the section if not required

@Ahmad-Elsayed Ahmad-Elsayed requested a review from a team as a code owner October 13, 2023 14:30
vadymv-mendix
vadymv-mendix previously approved these changes Oct 13, 2023
Copy link
Collaborator

@vadymv-mendix vadymv-mendix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@UrazAkgultan UrazAkgultan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the version number of the relevant widget and also update the CHANGELOG file?

@Ahmad-Elsayed Ahmad-Elsayed force-pushed the moo/MOO-1155-investigate-floating-action-button-warning-solution branch from c7df1bc to 48176df Compare October 17, 2023 08:54
@Ahmad-Elsayed Ahmad-Elsayed force-pushed the moo/MOO-1155-investigate-floating-action-button-warning-solution branch from 48176df to 038c087 Compare October 17, 2023 09:00
UrazAkgultan
UrazAkgultan previously approved these changes Oct 17, 2023
@Ahmad-Elsayed Ahmad-Elsayed force-pushed the moo/MOO-1155-investigate-floating-action-button-warning-solution branch from 038c087 to 4414a0d Compare October 17, 2023 15:09
@Ahmad-Elsayed Ahmad-Elsayed merged commit 8eecd46 into main Oct 23, 2023
11 checks passed
@Ahmad-Elsayed Ahmad-Elsayed deleted the moo/MOO-1155-investigate-floating-action-button-warning-solution branch October 23, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants