Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine/Coarse Location Permission Checking for Request Location Permission #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fine/Coarse Location Permission Checking for Request Location Permission #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a80d26
Update RequestLocationPermission.ts
skullquake Aug 14, 2023
23493a0
Coarse/Fine checking order
Aug 14, 2023
3347eb6
Merge branch 'mendix:main' into main
skullquake Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 63 additions & 4 deletions packages/jsActions/nanoflow-actions-native/src/geolocation/RequestLocationPermission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export async function RequestLocationPermission(): Promise<boolean> {
});
};

const hasPermissionAndroid = async (): Promise<boolean | undefined> => {
const hasPermissionAndroidFine = async (): Promise<boolean | undefined> => {
if (typeof reactNativeModule?.Platform?.Version === "number" && reactNativeModule?.Platform?.Version < 23) {
return true;
}
Expand Down Expand Up @@ -97,21 +97,58 @@ export async function RequestLocationPermission(): Promise<boolean> {
);
};

const hasPermissionAndroidCoarse = async (): Promise<boolean | undefined> => {
if (typeof reactNativeModule?.Platform?.Version === "number" && reactNativeModule?.Platform?.Version < 23) {
return true;
}

const androidLocationPermission = reactNativeModule?.PermissionsAndroid.PERMISSIONS.ACCESS_COARSE_LOCATION;

if (!androidLocationPermission) {
return false;
}

return reactNativeModule?.PermissionsAndroid.check(androidLocationPermission).then(hasPermission =>
hasPermission
? true
: reactNativeModule?.PermissionsAndroid?.request(androidLocationPermission).then(status => {
if (status === reactNativeModule?.PermissionsAndroid.RESULTS.GRANTED) {
return true;
}

if (status === reactNativeModule?.PermissionsAndroid.RESULTS.DENIED) {
reactNativeModule.ToastAndroid.show(
"Location permission denied by user.",
reactNativeModule.ToastAndroid.LONG
);
} else if (status === reactNativeModule?.PermissionsAndroid.RESULTS.NEVER_ASK_AGAIN) {
reactNativeModule.ToastAndroid.show(
"Location permission revoked by user.",
reactNativeModule.ToastAndroid.LONG
);
}

return false;
})
);
};


const hasLocationPermission = async (): Promise<boolean> => {
if (reactNativeModule?.Platform.OS === "ios") {
const hasPermission = await hasPermissionIOS();
return hasPermission;
}

if (reactNativeModule?.Platform.OS === "android") {
const hasPermission = await hasPermissionAndroid();
const hasPermission = await hasPermissionAndroidCoarse() || await hasPermissionAndroidFine();
return hasPermission ?? false;
}

return Promise.reject(new Error("Unsupported platform"));
};

const hasLocationPermissionForOldLibrary = async (): Promise<boolean | undefined> => {
const hasLocationPermissionForOldLibraryFine = async (): Promise<boolean | undefined> => {
if (reactNativeModule?.Platform.OS === "android") {
const locationPermission = reactNativeModule.PermissionsAndroid.PERMISSIONS.ACCESS_FINE_LOCATION;

Expand All @@ -133,6 +170,28 @@ export async function RequestLocationPermission(): Promise<boolean> {

return false;
};
const hasLocationPermissionForOldLibraryCoarse = async (): Promise<boolean | undefined> => {
if (reactNativeModule?.Platform.OS === "android") {
const locationPermission = reactNativeModule.PermissionsAndroid.PERMISSIONS.ACCESS_COARSE_LOCATION;

return reactNativeModule.PermissionsAndroid.check(locationPermission).then(hasPermission =>
hasPermission
? true
: reactNativeModule?.PermissionsAndroid.request(locationPermission).then(
status => status === reactNativeModule?.PermissionsAndroid.RESULTS.GRANTED
)
);
} else if (geolocationModule && (geolocationModule as GeolocationStatic).requestAuthorization) {
try {
(geolocationModule as GeolocationStatic).requestAuthorization();
return Promise.resolve(true);
} catch (error) {
return Promise.reject(error);
}
}

return false;
};

if (navigator && navigator.product === "ReactNative") {
reactNativeModule = require("react-native");
Expand All @@ -146,7 +205,7 @@ export async function RequestLocationPermission(): Promise<boolean> {
return hasLocationPermission();
} else if (reactNativeModule.NativeModules.RNCGeolocation) {
geolocationModule = Geolocation;
return (await hasLocationPermissionForOldLibrary()) ?? false;
return (await hasLocationPermissionForOldLibraryCoarse() || await hasLocationPermissionForOldLibraryFine() ) ?? false;
} else {
return Promise.reject(new Error("Geolocation module could not be found"));
}
Expand Down
Loading