Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar-chart-native): crash with Mx10 #64

Conversation

Ahmad-Elsayed
Copy link
Contributor

@Ahmad-Elsayed Ahmad-Elsayed commented Jul 28, 2023

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 8️⃣, 9️⃣, 🔟
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

Fix crash that appeared while using bar chart widget on native profiles with Mx10

Relevant changes

using editableValue.get(item) instead of editableValue(item)

What should be covered while testing?

_ Bar chart widget should act the same expected way on Mx8, Mx9, and Mx10_

@Ahmad-Elsayed Ahmad-Elsayed requested a review from a team as a code owner July 28, 2023 11:57
@Ahmad-Elsayed Ahmad-Elsayed changed the title fix(bar-chart-native: crash with Mx10 fix(bar-chart-native): crash with Mx10 Jul 28, 2023
@Ahmad-Elsayed Ahmad-Elsayed merged commit b059dc0 into main Jul 31, 2023
6 checks passed
@Ahmad-Elsayed Ahmad-Elsayed deleted the MOO-1118-error-with-bar-chart-for-native-when-running-in-mx-10 branch July 31, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants