Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-RPC errors are sent as string instead of object, not following JSON-RPC spec #102

Open
craigraw opened this issue Sep 10, 2024 · 0 comments · May be fixed by #103
Open

JSON-RPC errors are sent as string instead of object, not following JSON-RPC spec #102

craigraw opened this issue Sep 10, 2024 · 0 comments · May be fixed by #103

Comments

@craigraw
Copy link
Collaborator

This issue is essentially a duplicate of romanz/electrs#313, which was fixed in romanz/electrs#390, romanz/electrs#398 and romanz/electrs#421 (as far as I can see - branching makes it a bit confusing).

Errors are returned as a string instead of an object. Here is an example of a batched response error:

[{"error":"verbose transactions are currently unsupported","id":204,"jsonrpc":"2.0"}]

which should be returned as

[{"error":{"code":-32601,"message":"verbose transactions are currently unsupported"},"id":204,"jsonrpc":"2.0"}]

following the JSON-RPC 2.0 spec.

Unfortunately this is a blocker for upgrading to batched JSON-RPC support on Sparrow currently.

@junderw junderw linked a pull request Sep 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant