struct Rav1dFrameData::{mvs,ref_mvs}: Arcify with Option<DisjointMutArcSlice<refmvs_temporal_block>>s
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/struct-RefMvsFrame-rp_ref-field-remove
branch
from
233f0ae
to
d3f252e
Compare
kkysen
commented
Apr 19, 2024
Comment on lines
+4899
to
4903
| f.mvs = Some( | ||
| (0..f.sb128h as usize * 16 * (f.b4_stride >> 1) as usize) | ||
| .map(|_| Default::default()) | ||
| .collect(), | ||
| ); |
There was a problem hiding this comment.
This took way too long to debug, so annoying. I forgot the Some here, which may the .collect() and Default::default() use Option's impl FromIterator instead of into an Arc<[_]>.
… side of the `fn` ptr boundary).
|
Figured out the bugs now, so only need one person to review it. |
kkysen
force-pushed
the
kkysen/mvs-Arc
branch
2 times, most recently
from
9bfcd01
to
6f0cc65
Compare
…ntMutArcSlice<refmvs_temporal_block>>`s.
…vs_pool` now that `mvs`s have been `Arc`ified.
randomPoison
approved these changes
Apr 19, 2024
Base automatically changed from
kkysen/struct-RefMvsFrame-rp_ref-field-remove
to
main
April 19, 2024 19:50
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{,ref_}mvs{,_ref}fields ofRav1dFrameContext: Make fields safe #713.refmvs{,_pool}fields offn rav1d_ref_create_using_pool: Replace withArc::new#641.