Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum TxClass: make a real enum #879

Merged
merged 3 commits into from
Mar 21, 2024
Merged

enum TxClass: make a real enum #879

merged 3 commits into from
Mar 21, 2024

Conversation

folkertdev
Copy link
Collaborator

No description provided.

folkertdev
folkertdev commented Mar 21, 2024
View reviewed changes
src/recon.rs Show resolved Hide resolved
src/recon.rs Show resolved Hide resolved
randomPoison
randomPoison approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct, and I think replacing the various constants with tx_class should help us to deduplicate that code down the line 👍

kkysen
kkysen approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen an if if in the wild before 🤣.

src/levels.rs Outdated Show resolved Hide resolved
@kkysen kkysen merged commit 96f872d into main Mar 21, 2024
36 checks passed
@kkysen kkysen deleted the tx-class-enum branch March 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomPoison randomPoison randomPoison approved these changes

@kkysen kkysen kkysen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folkertdev @randomPoison @kkysen