-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enum BlockLevel
: Make a real enum
#760
Conversation
b1c7797
to
1f587c0
Compare
Hey @folkertdev, I was working on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I opened #762 now.
2836d36
to
49b8c87
Compare
1f587c0
to
9b40ee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a handful of comments, but they're pretty much all stylistic so I'm going to approve now and we can merge once you've made any necessary updates.
a bit more experimental, and some naming choices to be made here. I'll leave some inline comments