`enum BlockLevel`: Make a real `enum` #760

folkertdev · 2024-02-23T14:50:13Z

a bit more experimental, and some naming choices to be made here. I'll leave some inline comments

src/decode.rs

src/intra_edge.rs

src/levels.rs

src/env.rs

kkysen · 2024-02-24T00:07:44Z

Hey @folkertdev, I was working on intra_edges.rs last night, too, and make it all safe and statically initialized. Sorry for the overlap; we'll have to merge a bunch of stuff. I didn't make things bitflags! or enums yet though.

kkysen

Also, I opened #762 now.

src/levels.rs

src/decode.rs

src/intra_edge.rs

src/env.rs

randomPoison

Looks good! I left a handful of comments, but they're pretty much all stylistic so I'm going to approve now and we can merge once you've made any necessary updates.

src/decode.rs

src/env.rs

src/intra_edge.rs

src/levels.rs

src/tables.rs

src/intra_edge.rs

folkertdev force-pushed the blocklevel-enum branch from b1c7797 to 1f587c0 Compare February 23, 2024 14:51

folkertdev commented Feb 23, 2024

View reviewed changes

kkysen requested changes Feb 24, 2024

View reviewed changes

src/levels.rs Outdated Show resolved Hide resolved

src/levels.rs Outdated Show resolved Hide resolved

kkysen changed the title ~~make BlockLevel an enum~~ enum BlockLevel: Make a real enum Feb 26, 2024

kkysen reviewed Feb 26, 2024

View reviewed changes

src/levels.rs Outdated Show resolved Hide resolved

folkertdev force-pushed the edge-flags-bitflags branch 2 times, most recently from 2836d36 to 49b8c87 Compare February 28, 2024 22:45

Base automatically changed from edge-flags-bitflags to main February 29, 2024 11:59

folkertdev added 3 commits February 29, 2024 14:05

enum BlockLevel: make a real enum

84d2746

enum BlockLevel: rename variants to follow rust naming conventions

52dbd48

comment on a bitshift that flips ordering

9b40ee3

folkertdev force-pushed the blocklevel-enum branch from 1f587c0 to 9b40ee3 Compare February 29, 2024 13:28

folkertdev commented Feb 29, 2024

View reviewed changes

src/decode.rs Outdated Show resolved Hide resolved

src/intra_edge.rs Show resolved Hide resolved

src/env.rs Outdated Show resolved Hide resolved

randomPoison approved these changes Feb 29, 2024

View reviewed changes

folkertdev added 4 commits February 29, 2024 19:25

let else -> expect

43ebafb

use Debug impl for nicer debug prints of BlockLevel

36f0faf

rework reordering logic

0030f8b

reorder imports

7d19d48

kkysen reviewed Feb 29, 2024

View reviewed changes

src/intra_edge.rs Show resolved Hide resolved

kkysen reviewed Feb 29, 2024

View reviewed changes

src/intra_edge.rs Outdated Show resolved Hide resolved

remove DefaultValue instance

b58e8d8

kkysen approved these changes Feb 29, 2024

View reviewed changes

kkysen merged commit b40cfa5 into main Feb 29, 2024
34 checks passed

kkysen deleted the blocklevel-enum branch February 29, 2024 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`enum BlockLevel`: Make a real `enum` #760

`enum BlockLevel`: Make a real `enum` #760

folkertdev commented Feb 23, 2024

kkysen commented Feb 24, 2024

kkysen left a comment

randomPoison left a comment

enum BlockLevel: Make a real enum #760

enum BlockLevel: Make a real enum #760

Conversation

folkertdev commented Feb 23, 2024

kkysen commented Feb 24, 2024

kkysen left a comment

Choose a reason for hiding this comment

randomPoison left a comment

Choose a reason for hiding this comment

`enum BlockLevel`: Make a real `enum` #760

`enum BlockLevel`: Make a real `enum` #760