fn decode_b: Performance improvements
#1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is inlined in C and we see a small performance improvement inlining it in Rust (~0.5% on a Ryzen 7700X for Chimera 8-bit).
The `f.a[t.a]` block context reference is constant throughout this function, but it appears that the function is too complex for the optimizer to not recompute this reference. Making it a local improves performance measurably (~1% on a Ryzen 7700X for 8-bit Chimera).
kkysen
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlines
backup2x8which is inlined in C and improves performance slightly.The
f.a[t.a]block context reference is constant throughoutdecode_b, but it appears that thefunction is too complex for the optimizer to not recompute this reference. Making it a local
improves performance measurably (~1% on a Ryzen 7700X for 8-bit Chimera).