fn small_memset: Remove the unused UP_TO == 64 case
#1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's never hit (I tried replacing the `*as_array(buf) = [val; 64]` arm with a panic and the tests all passed). This makes sense because the original C code only had `upto` values of 16 and 32.
kkysen
changed the title
UP_TO == 64 case in small_memset.fn small_memset: Remove the unused UP_TO == 64 case
kkysen
approved these changes
Jul 14, 2024
kkysen
reviewed
Jul 14, 2024
|
Yeah, it's not perf-related, just a code clarity / symmetry with the C code thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's never hit (I tried replacing the
*as_array(buf) = [val; 64]arm with a panic and the tests all passed). This makes sense because the original C code only haduptovalues of 16 and 32.