mod picture: Make fully safe
#1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/struct-MemPool
branch
from
86e32d9
to
3331e0f
Compare
kkysen
force-pushed
the
kkysen/mod-picture-safe
branch
from
45e83d3
to
ac1bd5a
Compare
There was a problem hiding this comment.
I don't think we can mark dav1d_default_picture_alloc and dav1d_default_picture_release as safe, they have unsafe preconditions that the caller needs to uphold in order to prevent UB. I think doing deny(unsafe_op_in_unsafe_fn) and calling out those safety requirements in the code is good, though.
Oh yeah, true. |
kkysen
force-pushed
the
kkysen/mod-picture-safe
branch
from
b045646
to
caee397
Compare
randomPoison
approved these changes
Apr 29, 2024
kkysen
force-pushed
the
kkysen/struct-MemPool
branch
from
f0eba74
to
12863d6
Compare
kkysen
force-pushed
the
kkysen/mod-picture-safe
branch
from
caee397
to
f4f697c
Compare
…ptr args, but make private and ensure they must be used safely.
kkysen
force-pushed
the
kkysen/mod-picture-safe
branch
from
f4f697c
to
57485ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picture.rs: Unsafe cleanup #859.