-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod picture
: Make fully safe
#1006
Conversation
86e32d9
to
3331e0f
Compare
45e83d3
to
ac1bd5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can mark dav1d_default_picture_alloc
and dav1d_default_picture_release
as safe, they have unsafe preconditions that the caller needs to uphold in order to prevent UB. I think doing deny(unsafe_op_in_unsafe_fn)
and calling out those safety requirements in the code is good, though.
Oh yeah, true. |
b045646
to
caee397
Compare
f0eba74
to
12863d6
Compare
caee397
to
f4f697c
Compare
…ptr args, but make private and ensure they must be used safely.
f4f697c
to
57485ec
Compare
picture.rs
: Unsafe cleanup #859.