Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unnecessary usize::try_froms with as casts #1344

Open
kkysen opened this issue Sep 9, 2024 · 0 comments
Open

Replace unnecessary usize::try_froms with as casts #1344

kkysen opened this issue Sep 9, 2024 · 0 comments
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future performance

Comments

@kkysen
Copy link
Collaborator

kkysen commented Sep 9, 2024

Replace usize::try_froms that were there to avoid overflow for lengths with unchecked as casts,
as we now bounds check, and overflow here is fine.
@kkysen kkysen added good first issue Good for newcomers low priority Issues that we would like to address at some point in the future performance labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkysen