Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[repr(C)] from types that don't need it #1339

Open
kkysen opened this issue Sep 9, 2024 · 0 comments
Open

Remove #[repr(C)] from types that don't need it #1339

kkysen opened this issue Sep 9, 2024 · 0 comments
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future performance refactoring Cleaning up transpiled code

Comments

@kkysen
Copy link
Collaborator

kkysen commented Sep 9, 2024

A bunch of types are still marked #[repr(C)] even though they no longer need to be. This can sometimes hinder performance/memory usage, as seen by #1333. We should also make sure the removal of #[repr(C)] for each type doesn't hurt performance either.
@kkysen kkysen added good first issue Good for newcomers low priority Issues that we would like to address at some point in the future performance refactoring Cleaning up transpiled code labels Sep 9, 2024
@kkysen kkysen mentioned this issue Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future performance refactoring Cleaning up transpiled code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkysen