From cb6e3029f355f3ac1b85b10da29fe197d2fafbe4 Mon Sep 17 00:00:00 2001 From: Stephen Crane Date: Wed, 4 Sep 2024 11:20:28 -0700 Subject: [PATCH 1/2] Make default logger stderr dav1d logs to stderr by default, we should be doing the same. --- src/lib.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib.rs b/src/lib.rs index 0b05febfa..6c9366eb0 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -43,6 +43,7 @@ use crate::src::internal::Rav1dTaskContextTaskThread; use crate::src::internal::TaskThreadData; use crate::src::iter::wrapping_iter; use crate::src::log::Rav1dLog as _; +use crate::src::log::Rav1dLogger; use crate::src::obu::rav1d_parse_obus; use crate::src::obu::rav1d_parse_sequence_header; use crate::src::picture::rav1d_picture_alloc_copy; @@ -119,7 +120,7 @@ impl Default for Rav1dSettings { all_layers: true, frame_size_limit: 0, allocator: Default::default(), - logger: Default::default(), + logger: Some(Rav1dLogger::default()), strict_std_compliance: false, output_invisible_frames: false, inloop_filters: Rav1dInloopFilterType::all(), From d7c08cf87aedb6ac1ea49210d708bcc0c81ef5a2 Mon Sep 17 00:00:00 2001 From: Stephen Crane Date: Wed, 4 Sep 2024 11:20:43 -0700 Subject: [PATCH 2/2] Fix length print when encountering an unknown OBU --- src/obu.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/obu.rs b/src/obu.rs index 20229fc85..53d7a25ff 100644 --- a/src/obu.rs +++ b/src/obu.rs @@ -2460,7 +2460,7 @@ fn parse_obus( Some(Rav1dObuType::Padding) => {} // Ignore OBUs we don't care about. None => { // Print a warning, but don't fail for unknown types. - let len = gb.len(); + let len = gb.remaining_len(); writeln!(c.logger, "Unknown OBU type {raw_type} of size {len}"); } }