Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panics when any environment variable contains non-unicode characters #579

Open
printfn opened this issue Oct 21, 2024 · 0 comments
Open

Comments

@printfn
Copy link

printfn commented Oct 21, 2024

This crate causes a panic if any environment variable contains non-unicode characters, such as when PWD points at a non-unicode directory, e.g. when running mkdir $'\xff'.

None => env::vars().for_each(collector),

This line needs to be changed to env::vars_os(), with appropriate Unicode escaping and/or filtering of unencodable environment variables.

Downstream issue: atuinsh/atuin#2428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant