You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Great project, but the code could use some improvement!
First off, I want to commend the work that has been done here. However, I've noticed that the code could benefit from some significant refactoring to improve readability and maintainability. While I don't have much time to contribute a PR myself, I believe these changes would greatly benefit the project's long-term development.
To start, here are a few key areas we could focus on:
Decouple and organize the code into smaller, more manageable components. This will make the codebase easier to navigate and maintain.
Refactor the main component. At a minimum, separate the header and source files to promote modularity.
Simplify and streamline the main.c file. Keep it as concise as possible, with all business logic extracted into other headers/components.
Integrate linting tools. ESP-IDF uses tools like pre-commit and astyle. Leveraging these here would help ensure code quality.
If anyone has the time to tackle these items, it would be a great step forward for the project!
The text was updated successfully, but these errors were encountered:
Great project, but the code could use some improvement!
First off, I want to commend the work that has been done here. However, I've noticed that the code could benefit from some significant refactoring to improve readability and maintainability. While I don't have much time to contribute a PR myself, I believe these changes would greatly benefit the project's long-term development.
To start, here are a few key areas we could focus on:
main
component. At a minimum, separate the header and source files to promote modularity.main.c
file. Keep it as concise as possible, with all business logic extracted into other headers/components.If anyone has the time to tackle these items, it would be a great step forward for the project!
The text was updated successfully, but these errors were encountered: