Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Add symfony progress component #38

Open
adam-paterson opened this issue Oct 4, 2016 · 7 comments
Open

Add symfony progress component #38

adam-paterson opened this issue Oct 4, 2016 · 7 comments
Assignees

Comments

@adam-paterson
Copy link
Contributor

adam-paterson commented Oct 4, 2016

It'd be great to use Symfony\Component\Console\Helper\ProgressBar to report put and get progress in the console.

@bobbyshaw
Copy link
Member

This would be nice, did you look into this?

@adam-paterson
Copy link
Contributor Author

Not yet, I was thinking of tackling some of the open issues on Friday actually.

@adam-paterson
Copy link
Contributor Author

This will require a big refactor sadly. The version of Symfony/Console which n98-magerun uses doesn't have the progress writer. We can alias the version we require but this could introduce a lot of issues.

We'd be better doing this after we remove the magerun dependancy.

@bobbyshaw
Copy link
Member

Yeah, I just looked again at removing magerun dependency and cba. I guess that's something we will will be pressured to do when looking at the Mage2 version.

@adam-paterson
Copy link
Contributor Author

I'm about half way there removing the magerun dep so I'll continue working on that before starting this.

@bobbyshaw
Copy link
Member

Oh wow, good effort. See #10 if you haven't already. Nick added an update a while back about using his library for some of the stuff.

@adam-paterson
Copy link
Contributor Author

Sure did, that's the approach I'm taking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants