Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support formatting #456

Open
4 tasks done
remcohaszing opened this issue Jul 9, 2024 · 2 comments
Open
4 tasks done

Support formatting #456

remcohaszing opened this issue Jul 9, 2024 · 2 comments
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on

Comments

@remcohaszing
Copy link
Member

Initial checklist

Problem

There’s no proper formatting solution yet for MDX. Prettier support is a work in progress (prettier/prettier#12209, prettier/prettier#13676). The remark CLI and language server don’t properly support MDX yet (mdx-js/mdx#2378, remarkjs/vscode-remark#129, unifiedjs/unified-engine#56).

Solution

The MDX language server can support formatting for MDX based on remark programmatically. This would be opiniated unconfigurable formatting.

Alternatives

  1. We could make it configurable. We could also do this later
  2. We could close this issue and not support formatting.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 9, 2024
@wooorm
Copy link
Member

wooorm commented Jul 9, 2024

sure I’m 👍

@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 🙆 yes/confirmed This is confirmed and ready to be worked on 👍 phase/yes Post is accepted and can be worked on labels Jul 9, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Hi! This was marked as ready to be worked on! Note that while this is ready to be worked on, nothing is said about priority: it may take a while for this to be solved.

Is this something you can and want to work on?

Team: please use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this. If this is first-timers friendly, add good first issue and if this could use help, add help wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on
Development

No branches or pull requests

2 participants