Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #544

Open
2 tasks done
basile-parent opened this issue Jul 23, 2024 · 1 comment
Open
2 tasks done

Improve accessibility #544

basile-parent opened this issue Jul 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@basile-parent
Copy link
Contributor

If you want to ask for support or request features, sponsor the project and contact me over email.

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • I have read the documentation and cannot find an answer.

Describe the bug
If found a few easy (and yet important) improvments on accessibility:

  • We cannot put id on the textarea field (div role="textbox") neither customizing its aria-label / aria-labelledby (set to aria-label="editable markdown") so we cannot customize the accessible name

image

  • All buttons have "radio" role which has no sense if they can be activated together (for exemple the bold, italic and underline buttons are independants, they shouldn't be specified by the "radio" role). Plus, the button type="button" is redundant. For me, the only button which should be identified as radio (and grouped into a proper fieldset) are:
    • The list buttons
    • The superscript / subscript buttons

image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Brave Version 1.50.120 | Chromium: 112.0.5615.121
@basile-parent basile-parent added the bug Something isn't working label Jul 23, 2024
@basile-parent
Copy link
Contributor Author

PR in 2 parts : #552 & #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant