fix: allow focusing an empty editor

Fixes #446
mdx-editor · May 4, 2024 · e2585b8 · e2585b8
1 parent 500b7ff
commit e2585b8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/examples/basics.tsx b/src/examples/basics.tsx
@@ -45,6 +45,16 @@ export function Bare() {
   )
 }
 
+export function FocusEmpty() {
+  const ref = React.useRef<MDXEditorMethods>(null)
+  return (
+    <>
+      <button onClick={() => ref.current?.focus()}>Focus</button>
+      <MDXEditor ref={ref} markdown="" placeholder="Hello..." onChange={console.log} />
+    </>
+  )
+}
+
 export function Placeholder() {
   return (
     <>

diff --git a/src/plugins/core/index.ts b/src/plugins/core/index.ts
@@ -898,10 +898,8 @@ export const corePlugin = realmPlugin<{
     })
 
     newEditor.update(() => {
-      const markdown = params?.initialMarkdown.trim()
-      if (markdown) {
-        tryImportingMarkdown(r, $getRoot(), markdown)
-      }
+      const markdown = params?.initialMarkdown.trim() ?? ''
+      tryImportingMarkdown(r, $getRoot(), markdown)
 
       const autoFocusValue = params?.autoFocus
       if (autoFocusValue) {