Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Duplicate student check #119

Open
mdwiltfong opened this issue Apr 21, 2022 · 0 comments
Open

Optimize Duplicate student check #119

mdwiltfong opened this issue Apr 21, 2022 · 0 comments
Assignees
@mdwiltfong
Labels
enhancement New feature or request

Comments

@mdwiltfong
Copy link
Owner

At the moment the app compares the student email entered during the creation of a quote to every student email associated with the teacher. This isn't scalable. It would be best to create a hash map:

capstone_one/models.py

Line 217 in 1cc941c

for student in teacher.students:

@mdwiltfong mdwiltfong added the enhancement New feature or request label Apr 21, 2022
@mdwiltfong mdwiltfong self-assigned this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdwiltfong mdwiltfong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdwiltfong