Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document user activation requirement of the Fullscreen API #22303

Closed
foolip opened this issue Nov 15, 2022 · 2 comments
Closed

Document user activation requirement of the Fullscreen API #22303

foolip opened this issue Nov 15, 2022 · 2 comments
Assignees
Labels
Content:WebAPI Web API docs effort: medium This task is a medium effort. help wanted If you know something about this topic, we would love your help!

Comments

@foolip
Copy link
Contributor

foolip commented Nov 15, 2022

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

Implementations of the Fullscreen API have always required "user activation" to go fullscreen, such as a click event. The documentation on MDN doesn't make any mention of this.

What did you expect to see?

Probably link to a common page describing user activation in general, and expand the toggleFullscreen() example to use a "click" event handler, so that it can be copy-pasted and basically work.

Do you have any supporting links, references, or citations?

In the spec this is documented here:
https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

And the requirement to consume the user gesture is being added here:
whatwg/fullscreen#153

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@github-actions github-actions bot added Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 15, 2022
@sideshowbarker sideshowbarker added help wanted If you know something about this topic, we would love your help! effort: medium This task is a medium effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Nov 16, 2022
@hamishwillee
Copy link
Collaborator

This is mentioned in the "Security" section: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen#security

Perhaps not visible enough. Propose #22387 as a fix.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Nov 21, 2022

@foolip I am closing this as "incorrect". The data is there, and in the intended place. The fact that the place was not sufficiently visible is a different problem. I am chasing up how that should be discussed in #22387

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs effort: medium This task is a medium effort. help wanted If you know something about this topic, we would love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants