Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Add spec_url to deprecated device-related @media features #24470

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Sep 19, 2024

According to the 2018 "Media Queries Level 4 specification draft", the device-width, device-height and device-aspect-ratio media features are deprecated. They are kept for backward compatibility, but should be avoided.

According to the 2018 "Media Queries Level 4 specification draft", the `device-width`, `device-height` and `device-aspect-ratio` media features are deprecated. They will be kept for backward compatibility, but should be avoided.
@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Sep 19, 2024
@ramiy ramiy changed the title feat(css): Add spec_url to deprecated device-related @media features feat(css): Add spec_url to deprecated device-related @media features Sep 20, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if they're deprecated, I would suggest linking to the features, not the parent section.

css/at-rules/media.json Outdated Show resolved Hide resolved
css/at-rules/media.json Outdated Show resolved Hide resolved
css/at-rules/media.json Outdated Show resolved Hide resolved
@ramiy ramiy requested a review from caugner October 3, 2024 15:58
@caugner caugner changed the title feat(css): Add spec_url to deprecated device-related @media features chore(css): Add spec_url to deprecated device-related @media features Oct 7, 2024
@caugner caugner merged commit 4544b3c into mdn:main Oct 7, 2024
6 checks passed
@ramiy ramiy deleted the patch-2 branch October 7, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants