Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async option is not true async 3.1.10 #764

Open
crh3675 opened this issue Jun 6, 2024 · 0 comments
Open

async option is not true async 3.1.10 #764

crh3675 opened this issue Jun 6, 2024 · 0 comments

Comments

@crh3675
Copy link

crh3675 commented Jun 6, 2024 •
edited
Loading

We are using 3.1.10 with NodeJS 20.9.0.

I read that there is an async option for rendering templates. Upon further inspection of the source code, this is not a real Async behavior as the internals of this library use these calls to load file data.

  • fs.existsSync
  • fs.readFileSync

Any hopes to Promisify these calls to be truly async?
@crh3675 crh3675 changed the title async option is true async 3.1.10 async option is not true async 3.1.10 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crh3675