Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do anything when the navbar is collapsed. #137

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Nov 23, 2015

This fixes #136.

@CWSpear
Copy link
Collaborator

CWSpear commented Nov 23, 2015

There is actually one thing I hadn't considered: What if there is a .navbar-toggle somewhere else visible on the page for any reason. This would break the functionality for all dropdowns unintentionally.

This is an issue that we have tried solving before: 6aba7e1 & #11, and I think there are others, but can't find them right off.

@jfly
Copy link
Contributor Author

jfly commented Nov 23, 2015

I see. It looks like the shouldHover method was removed in 0962a02.

I was stuck thinking that this plugin is only used for navbars. I did not realize that this is meant to be used for dropdowns anywhere on a page. I've changed the condition to only fire for dropdowns that are inside a navbar that is collapsed.

@CWSpear
Copy link
Collaborator

CWSpear commented Nov 24, 2015

Alright, I think that's better! Not at my computer, but I'll try and get this merged and a new version out sometime today.

@jfly
Copy link
Contributor Author

jfly commented Nov 30, 2015

Bump. Any news here?

CWSpear added a commit that referenced this pull request Dec 1, 2015
Don't do anything when the navbar is collapsed.
@CWSpear CWSpear merged commit c770fc4 into mdbootstrap:master Dec 1, 2015
@CWSpear
Copy link
Collaborator

CWSpear commented Dec 1, 2015

Thanksgiving holiday and all that jazz. Sorry about that. Thanks for the ping to remind me =)

Anyway, merged. I did a minor version bump since it could break some extreme edge cases. (Then did another patch bump). v2.2.1 is tagged and published. Thanks!

@jfly
Copy link
Contributor Author

jfly commented Dec 1, 2015

Sweet, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't do anything when navbar is collapsed
2 participants