From c9dc3b2ef3eab04b11d59b3c6ea5a7198a942b33 Mon Sep 17 00:00:00 2001
From: Hannah Purcell <69368883+hannahpurcell@users.noreply.github.com>
Date: Thu, 31 Oct 2024 11:29:30 -0400
Subject: [PATCH] tweak: Rename detourText to copyableDetourText, fix typo
 (#2879)

---
 .../components/detours/detourPanels/activeDetourPanel.tsx | 6 +++---
 .../detours/detourPanels/detourFinishedPanel.tsx          | 8 ++++----
 .../components/detours/detourPanels/pastDetourPanel.tsx   | 6 +++---
 assets/src/components/detours/diversionPage.tsx           | 6 +++---
 .../detours/activeDetourPanel.stories.tsx                 | 4 ++--
 .../detours/detourFinishedPanel.stories.tsx               | 2 +-
 .../skate-components/detours/pastDetourPanel.stories.tsx  | 4 ++--
 7 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/assets/src/components/detours/detourPanels/activeDetourPanel.tsx b/assets/src/components/detours/detourPanels/activeDetourPanel.tsx
index 3d4eff436..1a475e018 100644
--- a/assets/src/components/detours/detourPanels/activeDetourPanel.tsx
+++ b/assets/src/components/detours/detourPanels/activeDetourPanel.tsx
@@ -17,7 +17,7 @@ import {
 import inTestGroup, { TestGroups } from "../../../userInTestGroup"
 
 export interface ActiveDetourPanelProps extends PropsWithChildren {
-  detourText: string
+  copyableDetourText: string
   directions?: DetourDirection[]
   connectionPoints?: [string, string]
   missedStops?: Stop[]
@@ -30,7 +30,7 @@ export interface ActiveDetourPanelProps extends PropsWithChildren {
 }
 
 export const ActiveDetourPanel = ({
-  detourText,
+  copyableDetourText,
   directions,
   connectionPoints,
   missedStops,
@@ -63,7 +63,7 @@ export const ActiveDetourPanel = ({
         {backButton}
         {/* TODO: temporary test group until I get the copy logic hooked up */}
         {inTestGroup(TestGroups.CopyButton) && (
-          <CopyButton detourText={detourText} />
+          <CopyButton detourText={copyableDetourText} />
         )}
       </Panel.Header>
 
diff --git a/assets/src/components/detours/detourPanels/detourFinishedPanel.tsx b/assets/src/components/detours/detourPanels/detourFinishedPanel.tsx
index 2aa5d1fc9..7bf3ab8a4 100644
--- a/assets/src/components/detours/detourPanels/detourFinishedPanel.tsx
+++ b/assets/src/components/detours/detourPanels/detourFinishedPanel.tsx
@@ -11,7 +11,7 @@ import { Stop } from "../../../schedule"
 
 interface DetourFinishedPanelProps extends PropsWithChildren {
   onNavigateBack: () => void
-  detourText: string
+  copyableDetourText: string
   connectionPoints?: [string, string]
   missedStops?: Stop[]
   onChangeDetourText: (value: string) => void
@@ -20,7 +20,7 @@ interface DetourFinishedPanelProps extends PropsWithChildren {
 
 export const DetourFinishedPanel = ({
   onNavigateBack,
-  detourText,
+  copyableDetourText,
   connectionPoints,
   missedStops,
   onChangeDetourText,
@@ -30,7 +30,7 @@ export const DetourFinishedPanel = ({
   <Panel as="article" className="c-diversion-panel">
     <Panel.Header>
       <h1 className="c-diversion-panel__h1 my-3">View Draft Detour</h1>
-      <CopyButton detourText={detourText} />
+      <CopyButton detourText={copyableDetourText} />
     </Panel.Header>
 
     <Panel.Body className="d-flex flex-column">
@@ -46,7 +46,7 @@ export const DetourFinishedPanel = ({
 
         <Form.Control
           as="textarea"
-          value={detourText}
+          value={copyableDetourText}
           onChange={({ target: { value } }) => onChangeDetourText(value)}
           className="flex-grow-1 mb-3"
           style={{
diff --git a/assets/src/components/detours/detourPanels/pastDetourPanel.tsx b/assets/src/components/detours/detourPanels/pastDetourPanel.tsx
index a9b9b0010..6765d33f4 100644
--- a/assets/src/components/detours/detourPanels/pastDetourPanel.tsx
+++ b/assets/src/components/detours/detourPanels/pastDetourPanel.tsx
@@ -13,7 +13,7 @@ import {
 import inTestGroup, { TestGroups } from "../../../userInTestGroup"
 
 export interface PastDetourPanelProps {
-  detourText: string
+  copyableDetourText: string
   directions?: DetourDirection[]
   connectionPoints: [string, string]
   missedStops?: Stop[]
@@ -25,7 +25,7 @@ export interface PastDetourPanelProps {
 }
 
 export const PastDetourPanel = ({
-  detourText,
+  copyableDetourText,
   directions,
   connectionPoints,
   missedStops,
@@ -40,7 +40,7 @@ export const PastDetourPanel = ({
       <h1 className="c-diversion-panel__h1 my-3">View Past Detour</h1>
       {/* TODO: temporary test group until I get the copy logic hooked up */}
       {inTestGroup(TestGroups.CopyButton) && (
-        <CopyButton detourText={detourText} />
+        <CopyButton detourText={copyableDetourText} />
       )}
     </Panel.Header>
 
diff --git a/assets/src/components/detours/diversionPage.tsx b/assets/src/components/detours/diversionPage.tsx
index d29ac88a0..a1711b37d 100644
--- a/assets/src/components/detours/diversionPage.tsx
+++ b/assets/src/components/detours/diversionPage.tsx
@@ -260,7 +260,7 @@ export const DiversionPage = ({
       return (
         <DetourFinishedPanel
           onNavigateBack={editDetour}
-          detourText={textArea}
+          copyableDetourText={textArea}
           connectionPoints={[
             connectionPoints?.start?.name ?? "N/A",
             connectionPoints?.end?.name ?? "N/A",
@@ -350,7 +350,7 @@ export const DiversionPage = ({
     } else if (snapshot.matches({ "Detour Drawing": "Active" })) {
       return (
         <ActiveDetourPanel
-          detourText="Hello World"
+          copyableDetourText="Hello World"
           directions={extendedDirections}
           connectionPoints={[
             connectionPoints?.start?.name ?? "N/A",
@@ -391,7 +391,7 @@ export const DiversionPage = ({
     } else if (snapshot.matches({ "Detour Drawing": "Past" })) {
       return (
         <PastDetourPanel
-          detourText="Hello World"
+          copyableDetourText="Hello World"
           directions={extendedDirections}
           connectionPoints={[
             connectionPoints?.start?.name ?? "N/A",
diff --git a/assets/stories/skate-components/detours/activeDetourPanel.stories.tsx b/assets/stories/skate-components/detours/activeDetourPanel.stories.tsx
index c539027e6..7ad590cae 100644
--- a/assets/stories/skate-components/detours/activeDetourPanel.stories.tsx
+++ b/assets/stories/skate-components/detours/activeDetourPanel.stories.tsx
@@ -4,7 +4,7 @@ import React from "react"
 import { ActiveDetourPanel } from "../../../src/components/detours/detourPanels/activeDetourPanel"
 import { stopFactory } from "../../../tests/factories/stop"
 
-const defaulText = [
+const defaultText = [
   "Detour:",
   "66 Harvard via Allston from",
   "Andrew Station",
@@ -34,7 +34,7 @@ const meta = {
     stretch: true,
   },
   args: {
-    detourText: defaulText,
+    copyableDetourText: defaultText,
     directions: [
       { instruction: "Start at Centre St & John St" },
       { instruction: "Right on John St" },
diff --git a/assets/stories/skate-components/detours/detourFinishedPanel.stories.tsx b/assets/stories/skate-components/detours/detourFinishedPanel.stories.tsx
index f9a87ae70..85f3872a6 100644
--- a/assets/stories/skate-components/detours/detourFinishedPanel.stories.tsx
+++ b/assets/stories/skate-components/detours/detourFinishedPanel.stories.tsx
@@ -33,7 +33,7 @@ const meta = {
     stretch: true,
   },
   args: {
-    detourText: defaultText,
+    copyableDetourText: defaultText,
   },
   // The bootstrap CSS reset is supposed to set box-sizing: border-box by
   // default, we should be able to remove this after that is added
diff --git a/assets/stories/skate-components/detours/pastDetourPanel.stories.tsx b/assets/stories/skate-components/detours/pastDetourPanel.stories.tsx
index a5954b716..75d788126 100644
--- a/assets/stories/skate-components/detours/pastDetourPanel.stories.tsx
+++ b/assets/stories/skate-components/detours/pastDetourPanel.stories.tsx
@@ -4,7 +4,7 @@ import React from "react"
 import { PastDetourPanel } from "../../../src/components/detours/detourPanels/pastDetourPanel"
 import { stopFactory } from "../../../tests/factories/stop"
 
-const defaulText = [
+const defaultText = [
   "Detour:",
   "66 Harvard via Allston from",
   "Andrew Station",
@@ -34,7 +34,7 @@ const meta = {
     stretch: true,
   },
   args: {
-    detourText: defaulText,
+    copyableDetourText: defaultText,
     directions: [
       { instruction: "Start at Centre St & John St" },
       { instruction: "Right on John St" },