From 14855e5db99132f84b7823b3252aec11aeda56e3 Mon Sep 17 00:00:00 2001
From: Walton Hoops <me@waltonhoops.com>
Date: Wed, 18 Sep 2024 11:54:15 -0600
Subject: [PATCH] fix: use upload-artifact v4 to fix workflow failures

---
 .github/workflows/elixir.yml | 111 +++++++++++++++++------------------
 1 file changed, 55 insertions(+), 56 deletions(-)

diff --git a/.github/workflows/elixir.yml b/.github/workflows/elixir.yml
index fd055153..e2da2180 100644
--- a/.github/workflows/elixir.yml
+++ b/.github/workflows/elixir.yml
@@ -4,68 +4,67 @@ on:
   push:
   pull_request:
   schedule:
-    - cron: '0 5 * * *'
+    - cron: "0 5 * * *"
 
 env:
   BUILD_WITHOUT_QUIC: 1
 
 jobs:
   build:
-
     name: Build and test
-    runs-on: ubuntu-22.04 
+    runs-on: ubuntu-22.04
 
     steps:
-    - uses: actions/checkout@v2
-    # cache the ASDF directory, using the values from .tool-versions
-    - name: ASDF cache
-      uses: actions/cache@v2
-      with:
-        path: ~/.asdf
-        key: ${{ runner.os }}-asdf-v2-${{ hashFiles('.tool-versions') }}
-      id: asdf-cache
-    # only run `asdf install` if we didn't hit the cache
-    - uses: asdf-vm/actions/install@v1
-      if: steps.asdf-cache.outputs.cache-hit != 'true'
-    # if we did hit the cache, set up the environment
-    - name: Setup ASDF environment
-      run: |
-        echo "ASDF_DIR=$HOME/.asdf" >> $GITHUB_ENV
-        echo "ASDF_DATA_DIR=$HOME/.asdf" >> $GITHUB_ENV
-      if: steps.asdf-cache.outputs.cache-hit == 'true'
-    - name: Reshim ASDF
-      run: |
-        echo "$ASDF_DIR/bin" >> $GITHUB_PATH
-        echo "$ASDF_DIR/shims" >> $GITHUB_PATH
-        $ASDF_DIR/bin/asdf reshim
-    - name: Restore dependencies cache
-      id: deps-cache
-      uses: actions/cache@v2
-      with:
-        path: deps
-        key: ${{ runner.os }}-mix-${{ hashFiles('**/mix.lock') }}
-        restore-keys: ${{ runner.os }}-mix-
-    - name: Install dependencies
-      run: |
-        mix local.rebar --foce
-        mix local.hex --force
-        mix deps.get
-    - name: Compile (warnings as errors)
-      run: mix compile --force --warnings-as-errors
-    - name: Check formatting
-      run: mix format --check-formatted
-    - name: Credo
-      run: mix credo --strict
-    - name: Run tests
-      run: mix test --cover
-    - name: Save PR information
-      run: |
-        echo "${{ github.event.pull_request.number }}" > coverage/PR_NUMBER
-        echo "${{ github.event.pull_request.head.sha }}" > coverage/PR_SHA
-      if: github.event.pull_request
-    - name: Upload coverage artifact
-      uses: actions/upload-artifact@v2
-      with:
-        name: elixir-lcov
-        path: coverage/
-    - uses: mbta/actions/dialyzer@v1
+      - uses: actions/checkout@v2
+      # cache the ASDF directory, using the values from .tool-versions
+      - name: ASDF cache
+        uses: actions/cache@v2
+        with:
+          path: ~/.asdf
+          key: ${{ runner.os }}-asdf-v2-${{ hashFiles('.tool-versions') }}
+        id: asdf-cache
+      # only run `asdf install` if we didn't hit the cache
+      - uses: asdf-vm/actions/install@v1
+        if: steps.asdf-cache.outputs.cache-hit != 'true'
+      # if we did hit the cache, set up the environment
+      - name: Setup ASDF environment
+        run: |
+          echo "ASDF_DIR=$HOME/.asdf" >> $GITHUB_ENV
+          echo "ASDF_DATA_DIR=$HOME/.asdf" >> $GITHUB_ENV
+        if: steps.asdf-cache.outputs.cache-hit == 'true'
+      - name: Reshim ASDF
+        run: |
+          echo "$ASDF_DIR/bin" >> $GITHUB_PATH
+          echo "$ASDF_DIR/shims" >> $GITHUB_PATH
+          $ASDF_DIR/bin/asdf reshim
+      - name: Restore dependencies cache
+        id: deps-cache
+        uses: actions/cache@v2
+        with:
+          path: deps
+          key: ${{ runner.os }}-mix-${{ hashFiles('**/mix.lock') }}
+          restore-keys: ${{ runner.os }}-mix-
+      - name: Install dependencies
+        run: |
+          mix local.rebar --foce
+          mix local.hex --force
+          mix deps.get
+      - name: Compile (warnings as errors)
+        run: mix compile --force --warnings-as-errors
+      - name: Check formatting
+        run: mix format --check-formatted
+      - name: Credo
+        run: mix credo --strict
+      - name: Run tests
+        run: mix test --cover
+      - name: Save PR information
+        run: |
+          echo "${{ github.event.pull_request.number }}" > coverage/PR_NUMBER
+          echo "${{ github.event.pull_request.head.sha }}" > coverage/PR_SHA
+        if: github.event.pull_request
+      - name: Upload coverage artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: elixir-lcov
+          path: coverage/
+      - uses: mbta/actions/dialyzer@v1