Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use manifest.js file in mapshaper-gui #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasG77
Copy link

@ThomasG77 ThomasG77 commented Nov 11, 2021

With this PR, do

mapshaper-gui --manifest manifest.js and get a custom GUI using the existing manifest.js existing mechanism like below

Sélection_563

Follow-up to previous question from #511 and answer

Current limitation: do not deal with CORS issues like for URLs like https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/cultural/ne_10m_roads.zip
Also make options target, directSave, displayAll and quickView ignored due to overload by manifest.js file content
https://github.com/mbloch/mapshaper/blob/master/bin/mapshaper-gui#L204

Inherited from existing mechanism as https://mapshaper.org/?files=https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/cultural/ne_10m_roads.zip does not work whereas
https://mapshaper.org/?files=https://labs.webgeodatavore.com/partage/ne_10m_roads.zip works (same data, just with less limitations on CORS side)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant