We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I propose remove overridion of requiresAuthentication method prior to $code parameter detection
requiresAuthentication
$code
<?php # now protected function requiresAuthentication(Request $request) { if ( $this->httpUtils->checkRequestPath($request, $this->options['check_path']) || $this->httpUtils->checkRequestPath($request, $this->options['login_path']) ) { return true; } return false; } protected function attemptAuthentication(Request $request) { // redirect to auth provider if ($this->httpUtils->checkRequestPath($request, $this->options['login_path'])) { return $this->createProviderRedirectResponse($request); } $code = $request->get('code'); // ... } # I am propose to do protected function attemptAuthentication(Request $request) { $code = $request->get('code'); // redirect to auth provider if (!$code) { return $this->createProviderRedirectResponse($request); } // ... }
The text was updated successfully, but these errors were encountered:
Remove overridion of requiresAuthentication method (fixes mazen#15)
e15c5c8
7266244
No branches or pull requests
I propose remove overridion of
requiresAuthentication
method prior to$code
parameter detectionThe text was updated successfully, but these errors were encountered: