-
Notifications
You must be signed in to change notification settings - Fork 2.2k
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Allow user to configure date and amount format during transaction imports #863
Comments
Is this relevant if the user can set their date preference in the config issue: #909 , or should it still be provided here, but just set to the default of the user selected value, in case the format is different from the user's preferred option? Could you also elaborate a bit on the amount field? Note: Just stumbled upon this app and repo, and it looks cool. Hoping to engage with it over the coming weeks, cheers |
@MagnusHJensen yep, I think defaulting this select option to the user's preferred date format as specified in #909 is a good approach. In regards to the amount field, in most cases, a CSV will display "incomes" as a positive value and "expenses" as a negative value, but we cannot guarantee that. Since this app relies on the signage of the |
@zachgoll Alright, that makes sense. So amount would technically be only two options. |
@MagnusHJensen I would add an option. I had once a csv table with all amounts in negative (don't ask why not positive) and another column with the label "income" and "expense". |
Interesting setup haha. Then it comes down to how many custom/third-party solutions should be supported, and I can't advocate for anything there, since it's out of my scope/knowledge. |
@mamarguerat that's a great point, I've seen this format for a couple of my FIs too. To support that, I'm guessing we'd need an additional select where we ask the user the name of the column that designates the signage the transaction. For example, Mint data exports are in the following format: So in this case, we'd need the user to select "Transaction Type" from the column list. @justinfar this might affect the existing designs a little bit, but probably would be worth throwing in? |
@mamarguerat here are some updated designs from @justinfar that I think will work for this issue! |
Another option that I don't think was discussed earlier is having smart recognition of date formats. I have accounts under two banks and they use different formats, one following the ISO8601 format and the other However, all countries either use YMD, DMY, or MDY order for numerical dates. Banks always seem to use four-digit years, allowing easy automatic distinction between YMD and the other two. A simple consistency test could then almost always tell if a list of ordered dates is DMY or MDY, and any ambiguous entries could induce a user prompt. Does this seem like it would be straightforward to integrate? |
Is this issue related to a problem? Please describe.
Currently, the transaction imports feature requires users to input their data with the following convention:
YYYY-MM-DD
)Many users will be using the following flow to import data:
Most bank exports will include a "date" and "amount" field, but they will all be in different formats.
The user should be able to tell Maybe what those formats are to prevent an extra step of cleaning their exported bank data prior to importing it to Maybe
Describe the work that needs to be done to address this issue
Designs for this issue
https://www.figma.com/design/lonJmVk3HYkwZoIO7xYP2w/Maybe-App-(Community)?node-id=4199-214&t=dtAjwPnms0o6BmNx-0
The text was updated successfully, but these errors were encountered: