Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting limits if needed #43

Open
maxspahn opened this issue Feb 3, 2022 · 2 comments
Open

Resetting limits if needed #43

maxspahn opened this issue Feb 3, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@maxspahn
Copy link
Owner

maxspahn commented Feb 3, 2022

Currently the joint position/velocity/acceleration limits are hard coded. We should add a setter method to modify it according to the need of an application.

@maxspahn maxspahn added enhancement New feature or request help wanted Extra attention is needed labels Feb 3, 2022
@SkyloveQiu
Copy link
Contributor

For this part, should I create a function with args?

@maxspahn
Copy link
Owner Author

If you want to address this issue, I suggest to first address it in the planar environments, see https://github.com/maxspahn/gym_envs_planar
There is already an implementation for the point robot, see https://github.com/maxspahn/gym_envs_planar/blob/354288a67b7185843dcb2c917ade86974ac18607/planarenvs/point_robot/envs/point_robot_env.py#L44-L64

For this part, should I create a function with args?

Correct, a function called reset_limits for example in which you can change individual limits if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants